Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While trying to edit pervious data is missing in persistent menu #161

Open
arveenkumar55 opened this issue Dec 6, 2018 · 8 comments
Open
Assignees

Comments

@arveenkumar55
Copy link
Contributor

Current behavior:
When i am trying to edit previous data is missing in persistent menu.
Expected behavior:
When i am trying to edit previous data should display in persistent menu.
Reproduce steps:

  1. Login
  2. go to persistent menu
  3. enter data and save
  4. go to an other page
  5. go to persistent menu
    screenshot from 2018-12-06 17-10-59
    Paper Trail:
    Paper trail is not showing logs for staging.
    sentry logs:
    There were no sentry logs
    Browser:
    chrome
    Environment:
    staging
@saniasiddiqui
Copy link
Contributor

Assigning @arveenkumar55 for testing

@arveenkumar55
Copy link
Contributor Author

@saniasiddiqui this is working fine on skiboEngage but not working on skibochat, kindly look.

@jekram
Copy link

jekram commented Jan 22, 2019

@saniasiddiqui what is the next step here? when we start a task we should try to finish it.

@saniasiddiqui
Copy link
Contributor

OK, the problem here is that menu has been implemented on KiboEngage. The data is saved in KiboEngage and not accounts. The work to move the model and controller for menu into KiboEngage was done under task : #21 during restructure work.

We need to decide here, if the menu should be shown in KiboChat as well then work needs to be done in Accounts repository and menu data should be saved in accounts database. If not then we should hide persistent menu from KiboChat.
@sojharo please suggest.

@sojharo
Copy link
Collaborator

sojharo commented Jan 23, 2019

Please keep it on KiboEngage I think. The plan says it should be common logic. How was this done as part of KiboEngage only?

@saniasiddiqui
Copy link
Contributor

This was done in Kiboengage because of #21 in KiboEngage Repository. The logic needs to be moved to accounts and we need to make redirect API calls in KiboEngage And KiboChat.
I shall take up this task on Monday

@jekram
Copy link

jekram commented Feb 3, 2019

@saniasiddiqui @sojharo We missed this in the design of restructuring design? or the design was not followed

@saniasiddiqui
Copy link
Contributor

This is fixed. Marking it as resolved,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants