-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While trying to edit pervious data is missing in persistent menu #161
Comments
Assigning @arveenkumar55 for testing |
@saniasiddiqui this is working fine on skiboEngage but not working on skibochat, kindly look. |
@saniasiddiqui what is the next step here? when we start a task we should try to finish it. |
OK, the problem here is that menu has been implemented on KiboEngage. The data is saved in KiboEngage and not accounts. The work to move the model and controller for menu into KiboEngage was done under task : #21 during restructure work. We need to decide here, if the menu should be shown in KiboChat as well then work needs to be done in Accounts repository and menu data should be saved in accounts database. If not then we should hide persistent menu from KiboChat. |
Please keep it on KiboEngage I think. The plan says it should be common logic. How was this done as part of KiboEngage only? |
This was done in Kiboengage because of #21 in KiboEngage Repository. The logic needs to be moved to accounts and we need to make redirect API calls in KiboEngage And KiboChat. |
@saniasiddiqui @sojharo We missed this in the design of restructuring design? or the design was not followed |
This is fixed. Marking it as resolved, |
Current behavior:
When i am trying to edit previous data is missing in persistent menu.
Expected behavior:
When i am trying to edit previous data should display in persistent menu.
Reproduce steps:
Paper Trail:
Paper trail is not showing logs for staging.
sentry logs:
There were no sentry logs
Browser:
chrome
Environment:
staging
The text was updated successfully, but these errors were encountered: