Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move model and modify the menu to kiboengage service #21

Closed
sojharo opened this issue Oct 9, 2018 · 11 comments
Closed

Move model and modify the menu to kiboengage service #21

sojharo opened this issue Oct 9, 2018 · 11 comments
Assignees
@bjafri5
Labels
bug Something isn't working code complete resolved

Comments

@sojharo
Copy link
Collaborator

sojharo commented Oct 9, 2018

Just move model and modify the endpoints for menu in this
@sojharo
Copy link
Collaborator Author

sojharo commented Oct 12, 2018

Depends on accounts server and #5 for testing. This can be coded but not tested. Also if there is any change in current code of KiboPush due to integration testing with accounts server, then this would need that change if change affects this.

@bjafri5 bjafri5 self-assigned this Oct 12, 2018
@bjafri5 bjafri5 mentioned this issue Oct 15, 2018
Merged
@bjafri5
Copy link
Contributor

bjafri5 commented Oct 17, 2018

This is complete

@bjafri5
Copy link
Contributor

bjafri5 commented Oct 23, 2018

@saniasiddiqui please test

@saniasiddiqui
Copy link
Contributor

Testing blocked by #68.

@saniasiddiqui saniasiddiqui added blocked bug Something isn't working and removed blocked testing required labels Oct 25, 2018
@saniasiddiqui
Copy link
Contributor

Getting the following error while testing menu fetch.
image

@saniasiddiqui saniasiddiqui removed their assignment Oct 29, 2018
@bjafri5
Copy link
Contributor

bjafri5 commented Nov 2, 2018

Fixed. @saniasiddiqui please test

@saniasiddiqui
Copy link
Contributor

image
Getting the following error on creating menu.

@saniasiddiqui saniasiddiqui removed their assignment Nov 5, 2018
This was referenced Nov 5, 2018
Merged
Merged
@bjafri5
Copy link
Contributor

bjafri5 commented Nov 9, 2018

Fixed. @saniasiddiqui please test

@saniasiddiqui
Copy link
Contributor

saniasiddiqui commented Nov 9, 2018 •
edited
Loading

Please see, I am still getting the authentication error while creating the menu.
image

@saniasiddiqui saniasiddiqui removed their assignment Nov 9, 2018
@bjafri5 bjafri5 mentioned this issue Nov 9, 2018
Merged
@bjafri5
Copy link
Contributor

bjafri5 commented Nov 9, 2018

Fixed. @saniasiddiqui please test

@saniasiddiqui
Copy link
Contributor

Tested.

@saniasiddiqui saniasiddiqui removed their assignment Nov 11, 2018
@jekram jekram closed this as completed Nov 11, 2018
@saniasiddiqui saniasiddiqui mentioned this issue Jan 22, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjafri5 bjafri5

Labels
bug Something isn't working code complete resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jekram @sojharo @bjafri5 @saniasiddiqui