Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfreeze python version, fix collections import #125

Closed
wants to merge 10 commits into from
Closed

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Jan 11, 2024

This PR adds | fixes:

How to prepare for test:

  • ssh to ...
  • Install on stage:
    bash servers/resources/SERVER.scilifelab.se/update-[THIS_TOOL]-stage.sh [THIS-BRANCH-NAME]

How to test:

Expected outcome:

  • no crash on eg genmod annotate when installed with modern python

Review:

  • Code approved by
  • Tests executed by
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@dnil
Copy link
Collaborator Author

dnil commented Oct 24, 2024

Could use a review on this one as well now that we are essentially at EOL for Python 3.8. @fellen31 @jemten @torbjorgen?

Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we unpin 3.8 in Dockerfile.pytest, so that the tests uses a later version?

Could you also unpin 3.8 in the build and publish workflow, and add changes to changelog?

fellen31 and others added 9 commits October 24, 2024 10:36
* Add parameters for penalty and threshold

* Cleaning things up

* Cleaning up and changelog
* Fix #112 - change documentation link on README

* changed a few more refs from Måns original url to new org url

* action link
* Allow source and version in INFO header

* Bump version

---------

Co-authored-by: Daniel Nilsson <[email protected]>
@dnil
Copy link
Collaborator Author

dnil commented Oct 24, 2024

Ok, that was not a very clean merge. I think I will just make a new branch rather than messing even more with the history here.

@dnil dnil closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants