Allow "Source" and "Version" in INFO header #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnil
approved these changes
Oct 24, 2024
| @@ -56,6 +56,8 @@ def __init__(self): | |||
| Number=(?P<number>-?\d+|\.|[AGR]), | |||
| Type=(?P<type>Integer|Float|Flag|Character|String), | |||
| Description="(?P<desc>[^"]*)" | |||
| (?:,Source="(?P<source>[^"]+)")? | |||
| (?:,Version="(?P<version>[^"]+)")? | |||
| @@ -12,6 +12,41 @@ def test_parse_info(): | |||
| ## THEN assert it is added to the parser | |||
| assert 'MQ' in head.info_dict | |||
|
|
|||
| def test_parse_info_with_source(): | |||
No worries, I honestly had forgotten about this. Great to see that things are moving forward! |
dnil
added a commit
that referenced
this pull request
Oct 24, 2024
* Allow source and version in INFO header * Bump version --------- Co-authored-by: Daniel Nilsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds | fixes:
The fields "Source" and "Version" are optional in the INFO header lines according to the VCF specification (v4.2 and above), but the validation does not take this into account. This PR allows for these optional fields.
Review:
This version is a: