Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics endpoint #504

Merged
merged 9 commits into from
Nov 24, 2023
Merged

Analytics endpoint #504

merged 9 commits into from
Nov 24, 2023

Conversation

rodriguesk
Copy link
Member

@rodriguesk rodriguesk commented Nov 22, 2023

Detailed information:

Explain the details of making this change.
Please provide enough information so that others can review your pull request

Closing issues:

List all issues the pull request solve:

Test plan (required)

  • The PR contains new PyTest unit/integration tests for any function or functional added.
  • The PR changes existing PyTest unit/integration tests to keep all tests up to date.
  • The PR does not lead to degradation in unit test coverage.
  • Project parts affected by changes in this PR was tested manually on your local (using Postman or in any other way). List everything you've tested below:
    • Part 1
    • Part 2

@rodriguesk rodriguesk requested a review from danmash November 22, 2023 08:51
@rodriguesk
Copy link
Member Author

@danmash I'm not sure why it's failing. On my local machine it's passing all tests. Can you have a look?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f88c1a) 73.64% compared to head (588bd4c) 74.08%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #504      +/-   ##
===========================================
+ Coverage    73.64%   74.08%   +0.43%     
===========================================
  Files           82       86       +4     
  Lines         2618     2670      +52     
  Branches       315      315              
===========================================
+ Hits          1928     1978      +50     
- Misses         657      658       +1     
- Partials        33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodriguesk
Copy link
Member Author

Closes #503

@rodriguesk rodriguesk merged commit 7fec53e into develop Nov 24, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the analytics_endpoint branch November 24, 2023 14:08
rodriguesk added a commit that referenced this pull request Nov 24, 2023
* Removed flask-selfdoc from project.

* Update score_nodes.py

added relatedPersonalValues to the GET response of the /feed endpoint to include all the personal values associated with each climate change impact for user's feed.

* run linting

* optional parameter to skip recaptcha

* change spelling

* remove timedelta

* Update installation.md

instructions how to free up port 5000 on macs.

* Cm 499 delete account and data (#501)

* Black formatting

* Extra test to ensure deleted user can't login

* added api documentation

* #499 ondelete="SET NULL" or "CASCADE"

* #499 explicit ondelete action for user foreign keys

* Change route method from POST to DELETE

* switch POST documentation to DELETE in app/static/Climate-Mind_bundled.yml

---------

Co-authored-by: Daniil Mashkin <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>

* Analytics endpoint (#504)

* Initial commit for #503

* Modified 2 files

* Fixing some bugs

* Remove init not needed

Remove

* Fixed bugs

* clearer datetime string format documentation.

* Fixed bug with date time

* Lint

* #503 unittests fixed

---------

Co-authored-by: Daniil Mashkin <[email protected]>

---------

Co-authored-by: Jason Hutson <[email protected]>
Co-authored-by: Svenstar74 <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>
Copy link

sentry-io bot commented Dec 4, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SystemExit: 1 analytics.post_user_a_event View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants