Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete account and associated data #499

Closed
rodriguesk opened this issue Sep 17, 2023 · 1 comment · Fixed by #501
Closed

delete account and associated data #499

rodriguesk opened this issue Sep 17, 2023 · 1 comment · Fixed by #501
Labels
enhancement New feature or request

Comments

@rodriguesk
Copy link
Member

rodriguesk commented Sep 17, 2023 •
edited
Loading

User story

As a user, I want to delete my account, so I can have my data all removed from Climate mind.

Acceptance criteria

  • When I delete my account, then my user account is removed from the users table in the database and I can no longer login. database that can be deleted without making conversations I had with other users disappear or cause errors for those users.
  • Conversation data in the database that has been shared with other users does not get deleted as this has been consented to share already
  • endpoint is /user-account and DELETE
  • endpoint requires Authorization header and X-Session-Id header.
  • endpoint requires currentPassword in Body.
  • endpoint responses include 200 "Account deleted"
  • new endpoint documentation is included in the stoplight specs
@rodriguesk rodriguesk added the enhancement New feature or request label Sep 17, 2023
@rodriguesk
Copy link
Member Author

This issue is just for deleting the user account and not any other associated data. A separate issue/ user story will need to be made for deleting all associated data without generating errors for other users. And when do that consideration will need to be given for situation where a conversation was linked for user a account and user b account (if user B already has an account) and then either user A or user B deletes their account:

  • When I delete my account, then all associated data with my account is deleted from the database that can be deleted without making conversations I had with other users disappear or cause errors for those users.
  • Conversation data in the database that has been shared with other users does not get deleted as this has been consented to share already

@rodriguesk rodriguesk mentioned this issue Sep 25, 2023
Merged
danmash added a commit that referenced this issue Sep 30, 2023
@danmash
#499 ondelete="SET NULL" or "CASCADE"
2249058
danmash added a commit that referenced this issue Sep 30, 2023
@danmash
#499 black
2379955
danmash added a commit that referenced this issue Oct 3, 2023
@danmash
#499 explicit ondelete action for user foreign keys
d7cfa89
danmash added a commit that referenced this issue Oct 3, 2023
@danmash
#499 migration black
c2348b5
rodriguesk added a commit that referenced this issue Oct 8, 2023
@rodriguesk @danmash
Cm 499 delete account and data (#501)
9efd207 
* Black formatting

* Extra test to ensure deleted user can't login

* added api documentation

* #499 ondelete="SET NULL" or "CASCADE"

* #499 explicit ondelete action for user foreign keys

* Change route method from POST to DELETE

* switch POST documentation to DELETE in app/static/Climate-Mind_bundled.yml

---------

Co-authored-by: Daniil Mashkin <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>
rodriguesk added a commit that referenced this issue Oct 8, 2023
@rodriguesk @HutsonJason
@Svenstar74 @danmash
adds delete user account functionality (#502)
6b2d435 
* Removed flask-selfdoc from project.

* Update score_nodes.py

added relatedPersonalValues to the GET response of the /feed endpoint to include all the personal values associated with each climate change impact for user's feed.

* run linting

* optional parameter to skip recaptcha

* change spelling

* remove timedelta

* Update installation.md

instructions how to free up port 5000 on macs.

* Cm 499 delete account and data (#501)

* Black formatting

* Extra test to ensure deleted user can't login

* added api documentation

* #499 ondelete="SET NULL" or "CASCADE"

* #499 explicit ondelete action for user foreign keys

* Change route method from POST to DELETE

* switch POST documentation to DELETE in app/static/Climate-Mind_bundled.yml

---------

Co-authored-by: Daniil Mashkin <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>

---------

Co-authored-by: Jason Hutson <[email protected]>
Co-authored-by: Svenstar74 <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>
rodriguesk added a commit that referenced this issue Nov 24, 2023
@rodriguesk @HutsonJason
@Svenstar74 @danmash
Adds analytics endpoint (#505)
6a807ba 
* Removed flask-selfdoc from project.

* Update score_nodes.py

added relatedPersonalValues to the GET response of the /feed endpoint to include all the personal values associated with each climate change impact for user's feed.

* run linting

* optional parameter to skip recaptcha

* change spelling

* remove timedelta

* Update installation.md

instructions how to free up port 5000 on macs.

* Cm 499 delete account and data (#501)

* Black formatting

* Extra test to ensure deleted user can't login

* added api documentation

* #499 ondelete="SET NULL" or "CASCADE"

* #499 explicit ondelete action for user foreign keys

* Change route method from POST to DELETE

* switch POST documentation to DELETE in app/static/Climate-Mind_bundled.yml

---------

Co-authored-by: Daniil Mashkin <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>

* Analytics endpoint (#504)

* Initial commit for #503

* Modified 2 files

* Fixing some bugs

* Remove init not needed

Remove

* Fixed bugs

* clearer datetime string format documentation.

* Fixed bug with date time

* Lint

* #503 unittests fixed

---------

Co-authored-by: Daniil Mashkin <[email protected]>

---------

Co-authored-by: Jason Hutson <[email protected]>
Co-authored-by: Svenstar74 <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>
Co-authored-by: Daniil Mashkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cm 499 delete account and data ClimateMind/climatemind-backend
1 participant
@rodriguesk