Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix response close for getRowsUpdated(#1538) #1667

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix response close for getRowsUpdated(#1538) #1667

merged 1 commit into from
Jun 3, 2024

Conversation

wooEnrico
Copy link
Contributor

@wooEnrico wooEnrico commented Jun 3, 2024 •
edited by chernser
Loading

The reason for the modification is com.clickhouse.r2dbc.ClickHouseResult Object Construction Parameters com.clickhouse.client.ClickHouseResponse did not call the close() method after use and did not release the database connection. Therefore, multiple calls can cause the database connection pool to have no available connections, resulting in timeout issues

Please refer to the problem description and code reproduction method for details #1538

This was referenced Jun 3, 2024
Merged
Merged
@wooEnrico
Copy link
Contributor Author

The reason for the modification is com.clickhouse.r2dbc.ClickHouseResult Object Construction Parameters com.clickhouse.client.ClickHouseResponse did not call the close() method after use and did not release the database connection. Therefore, multiple calls can cause the database connection pool to have no available connections, resulting in timeout issues

Please refer to the problem description and code reproduction method for details #1538

@chernser chernser merged commit 5c7b40a into ClickHouse:main Jun 3, 2024
58 checks passed
@chernser chernser linked an issue Jun 3, 2024 that may be closed by this pull request
clickhouse-r2dbc program is blocked by ClickHouseResponse #1538
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chernser chernser chernser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clickhouse-r2dbc program is blocked by ClickHouseResponse
2 participants
@wooEnrico @chernser