Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix response close for getRowsUpdated(#1538) #1539

Merged
merged 1 commit into from
May 30, 2024

Conversation

wooEnrico
Copy link
Contributor

@wooEnrico wooEnrico commented Jan 30, 2024

Summary

Mono resource manager for updateCount close the response when complete

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2024

CLA assistant check
All committers have signed the CLA.

@chernser
Copy link
Contributor

@wooEnrico would you please resubmit your PR? I have accidently merge it but it broke com.clickhouse.r2dbc.spi.test.R2DBCTestKitImplTest.segmentSelectWithEmitsRow what is part of 3rd-party test library.

Please also put more description about why this change is needed and what is the problem with current code.

Thanks!

@wooEnrico
Copy link
Contributor Author

I have improved the submission and passed the unit test. And I hope you can review #1667 again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants