-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some rain variables ClimaCore fields #512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 4, 2021
512: Make some rain variables ClimaCore fields r=charleskawczynski a=charleskawczynski This PR makes some rain variables ClimaCore fields, and removes the `UpdraftThermodynamics` struct. Peeled off from #506. Co-authored-by: Charles Kawczynski <[email protected]>
charleskawczynski
force-pushed
the
ck/more_fields5
branch
from
November 4, 2021 04:56
4a82b59
to
f6994f1
Compare
Canceled. |
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 4, 2021
512: Make some rain variables ClimaCore fields r=charleskawczynski a=charleskawczynski This PR makes some rain variables ClimaCore fields, and removes the `UpdraftThermodynamics` struct. Peeled off from #506. Co-authored-by: Charles Kawczynski <[email protected]>
Build failed: |
charleskawczynski
force-pushed
the
ck/more_fields5
branch
from
November 4, 2021 15:28
f6994f1
to
dfde467
Compare
charleskawczynski
force-pushed
the
ck/more_fields5
branch
from
November 4, 2021 15:33
dfde467
to
495092c
Compare
bors r+ |
Build succeeded: |
charleskawczynski
referenced
this pull request
Nov 9, 2021
511: Use relaxation to LES profiles + define initial conditions more precisely for LES_driven_SCM r=costachris a=costachris Addresses points 4, 7 from #505. Averages 1 hour window around `t_end` - 6 hours for initial conditions. `thetali` and `qt` are relaxed to the mean LES profile following eqn 9 in Shen et al. 2021 Co-authored-by: costachris <[email protected]>
charleskawczynski
referenced
this pull request
Nov 9, 2021
545: Bump version for new release r=charleskawczynski a=charleskawczynski Co-authored-by: Charles Kawczynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some rain variables ClimaCore fields, and removes the
UpdraftThermodynamics
struct. Peeled off from #506.