Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some rain variables ClimaCore fields #512

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Make some rain variables ClimaCore fields #512

merged 2 commits into from
Nov 4, 2021

Conversation

charleskawczynski
Copy link
Member

This PR makes some rain variables ClimaCore fields, and removes the UpdraftThermodynamics struct. Peeled off from #506.

@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Nov 4, 2021
512: Make some rain variables ClimaCore fields r=charleskawczynski a=charleskawczynski

This PR makes some rain variables ClimaCore fields, and removes the `UpdraftThermodynamics` struct. Peeled off from #506.

Co-authored-by: Charles Kawczynski <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 4, 2021

Canceled.

@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Nov 4, 2021
512: Make some rain variables ClimaCore fields r=charleskawczynski a=charleskawczynski

This PR makes some rain variables ClimaCore fields, and removes the `UpdraftThermodynamics` struct. Peeled off from #506.

Co-authored-by: Charles Kawczynski <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 4, 2021

Build failed:

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 4, 2021

Build succeeded:

@bors bors bot merged commit e882a5a into main Nov 4, 2021
@bors bors bot deleted the ck/more_fields5 branch November 4, 2021 15:56
charleskawczynski referenced this pull request Nov 9, 2021
511: Use relaxation to LES profiles + define initial conditions more precisely for LES_driven_SCM r=costachris a=costachris

Addresses points 4, 7 from #505. 
Averages 1 hour window around `t_end` - 6 hours for initial conditions. `thetali` and `qt` are relaxed to the mean LES profile following eqn 9 in Shen et al. 2021


Co-authored-by: costachris <[email protected]>
charleskawczynski referenced this pull request Nov 9, 2021
545: Bump version for new release r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant