Prepare data structures for adding snow #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
force-pushed
the
aj/snow_data_layout
branch
from
f8f321a
to
dfc44c1
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 3, 2021
506: Prepare data structures for adding snow r=charleskawczynski a=trontrytel This PR adds all the data structures for storing snow and its tendencies. Right now all the source terms related to snow are still set to zero. So this PR should not bring any changes. Co-authored-by: Anna Jaruga <[email protected]>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 3, 2021
506: Prepare data structures for adding snow r=charleskawczynski a=trontrytel This PR adds all the data structures for storing snow and its tendencies. Right now all the source terms related to snow are still set to zero. So this PR should not bring any changes. 509: lets see if it helps CI r=charleskawczynski a=trontrytel Co-authored-by: Anna Jaruga <[email protected]>
trontrytel
force-pushed
the
aj/snow_data_layout
branch
from
dfc44c1
to
607b0f6
Compare
|
Canceled. |
|
Let's see the CI plots. I want to double check I'm not changing anything for RiCO |
trontrytel
force-pushed
the
aj/snow_data_layout
branch
from
607b0f6
to
b538319
Compare
|
Oh, yeah, something is wrong with Rico |
bors bot
added a commit
that referenced
this pull request
Nov 4, 2021
512: Make some rain variables ClimaCore fields r=charleskawczynski a=charleskawczynski This PR makes some rain variables ClimaCore fields, and removes the `UpdraftThermodynamics` struct. Peeled off from #506. Co-authored-by: Charles Kawczynski <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 4, 2021
512: Make some rain variables ClimaCore fields r=charleskawczynski a=charleskawczynski This PR makes some rain variables ClimaCore fields, and removes the `UpdraftThermodynamics` struct. Peeled off from #506. Co-authored-by: Charles Kawczynski <[email protected]>
This was referenced Nov 4, 2021
Merged
bors bot
added a commit
that referenced
this pull request
Nov 4, 2021
514: add snow advection r=charleskawczynski a=trontrytel Another peel off from #506 . This one adds snow advection. Does not change RiCO. (looks like the change is somewhere in updraft tendencies then) Co-authored-by: Anna Jaruga <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 4, 2021
513: move env_thermo precip arrays to aux r=charleskawczynski a=trontrytel Peel off from #506 - moves environment precipitation related data structures to aux. (does not affect RiCO) Co-authored-by: Anna Jaruga <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 4, 2021
512: Make some rain variables ClimaCore fields r=charleskawczynski a=charleskawczynski This PR makes some rain variables ClimaCore fields, and removes the `UpdraftThermodynamics` struct. Peeled off from #506. Co-authored-by: Charles Kawczynski <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 4, 2021
513: move env_thermo precip arrays to aux r=trontrytel a=trontrytel Peel off from #506 - moves environment precipitation related data structures to aux. (does not affect RiCO) Co-authored-by: Anna Jaruga <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 4, 2021
515: Additional data structs for snow r=trontrytel a=trontrytel The last of the peel offs from #506 Hopefully no changes as well. 🤞 Co-authored-by: Anna Jaruga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all the data structures for storing snow and its tendencies. Right now all the source terms related to snow are still set to zero. So this PR should not bring any changes.