Make mse computations more flexible for new vars #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
Build succeeded: |
Merged
bors bot
added a commit
that referenced
this pull request
Oct 27, 2021
460: Fix mse bug r=charleskawczynski a=charleskawczynski I just saw that `main` broke because I forgot to consider the case where we don't have a new variable, but `best_mse[tc_var]` is a string, in which case we need to persist with using "NA". This was missed in #458. Co-authored-by: Charles Kawczynski <[email protected]>
charleskawczynski
referenced
this pull request
Nov 1, 2021
490: Bump version for new release r=charleskawczynski a=charleskawczynski Co-authored-by: Charles Kawczynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One last fix for #395.