Skip to content

Commit

Permalink
Merge #460
Browse files Browse the repository at this point in the history
460: Fix mse bug r=charleskawczynski a=charleskawczynski

I just saw that `main` broke because I forgot to consider the case where we don't have a new variable, but `best_mse[tc_var]` is a string, in which case we need to persist with using "NA". This was missed in #458.

Co-authored-by: Charles Kawczynski <[email protected]>
  • Loading branch information
bors[bot] and charleskawczynski authored Oct 27, 2021
2 parents 03f2111 + 3038c4f commit 4243d5e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion integration_tests/utils/compute_mse.jl
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ function compute_mse(case_name, best_mse, plot_dir; ds_dict, plot_comparison = t

haskey(best_mse, tc_var) || error("No key found in best_mse for variable $tc_var")

if new_variable
if new_variable || best_mse[tc_var] isa String
mse[tc_var] = "NA"
push!(mse_reductions, "NA")
push!(table_best_mse, "NA")
Expand Down

0 comments on commit 4243d5e

Please sign in to comment.