Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference state profile plots to docs #29

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Add reference state profile plots to docs #29

merged 1 commit into from
Jul 20, 2021

Conversation

charleskawczynski
Copy link
Member

This will be helpful to verify that the reference state profiles don't change too dramatically in #25.

@codecov
Copy link

codecov bot commented Jul 20, 2021 •
edited
Loading

Codecov Report

Merging #29 (3219837) into main (f6d3fad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #29   +/-   ##
=====================================
  Coverage   0.02%   0.02%           
=====================================
  Files         22      22           
  Lines       3468    3468           
=====================================
  Hits           1       1           
  Misses      3467    3467

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d3fad...3219837. Read the comment docs.

haakon-e
haakon-e approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@haakon-e haakon-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the bottom and left sides of the figures don't fit the documentation frame, i.e. the plot labels are slightly hidden. Otherwise, looks good.

@charleskawczynski
Copy link
Member Author

Yeah, let me see if I can fix that

@charleskawczynski
Copy link
Member Author

Thanks for taking a look!

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 20, 2021

Build succeeded:

@bors bors bot merged commit bdd61d3 into main Jul 20, 2021
@bors bors bot deleted the ck/ref_profiles branch July 20, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakon-e haakon-e haakon-e approved these changes

@trontrytel trontrytel Awaiting requested review from trontrytel

@szy21 szy21 Awaiting requested review from szy21

@yairchn yairchn Awaiting requested review from yairchn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @haakon-e