Use Thermodynamics.jl for reference state profiles #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/param_set
branch
from
f4e64d4
to
4c65fda
Compare
bors bot
added a commit
that referenced
this pull request
Jul 20, 2021
27: Fix nh pressure index, as this is indexing into OffsetArray r=charleskawczynski a=charleskawczynski #25 exercises the case where `alen` is equal to the length of `avals`. As this is an offset array, the proper translation was to use `xrange`, which effectively means indexing with `0:alen-1`. Co-authored-by: Charles Kawczynski <[email protected]>
charleskawczynski
force-pushed
the
ck/param_set
branch
from
4c65fda
to
33da106
Compare
bors bot
added a commit
that referenced
this pull request
Jul 20, 2021
29: Add reference state profile plots to docs r=charleskawczynski a=charleskawczynski This will be helpful to verify that the reference state profiles don't change too dramatically in #25. Co-authored-by: Charles Kawczynski <[email protected]>
charleskawczynski
force-pushed
the
ck/param_set
branch
2 times, most recently
from
6862ad2
to
93f998a
Compare
charleskawczynski
force-pushed
the
ck/param_set
branch
6 times, most recently
from
d5de1cf
to
84985d3
Compare
|
** Do not merge yet ** Examining the Artifacts, there are many in which the difference is acceptable but some that are not acceptable. |
Merged
bors bot
added a commit
that referenced
this pull request
Jul 21, 2021
35: Add climaparameters dep r=charleskawczynski a=charleskawczynski This peels off non-behavior changes from #25: - Dependence of CLIMAParameters added - Parameter sets become available in many functions - Parameter sets are read from the namelist file Note that parameter sets become available, but are not yet used. Co-authored-by: Charles Kawczynski <[email protected]>
charleskawczynski
force-pushed
the
ck/param_set
branch
from
84985d3
to
7e83f4c
Compare
charleskawczynski
changed the title
charleskawczynski
force-pushed
the
ck/param_set
branch
from
7e83f4c
to
061a384
Compare
yairchn
reviewed
Jul 24, 2021
This was referenced Jul 28, 2021
bors bot
added a commit
that referenced
this pull request
Jul 28, 2021
51: Fix inversion height bug, read Ri bulk crit from namelist, add Nieuwstadt case r=charleskawczynski a=charleskawczynski I believe this fixes the Nieuwstadt case. This may also fix / improve other cases. cc `@yairchn.` Looking forward to re-try #25, #40, and #43. Co-authored-by: Charles Kawczynski <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jul 28, 2021
51: Fix inversion height bug, read Ri bulk crit from namelist, add Nieuwstadt case r=charleskawczynski a=charleskawczynski I believe this fixes the Nieuwstadt case. This may also fix / improve other cases. cc `@yairchn.` Looking forward to re-try #25, #40, and #43. Co-authored-by: Charles Kawczynski <[email protected]>
charleskawczynski
force-pushed
the
ck/param_set
branch
2 times, most recently
from
74e3951
to
42b9290
Compare
charleskawczynski
force-pushed
the
ck/param_set
branch
5 times, most recently
from
0ed30b8
to
ea8cf8c
Compare
charleskawczynski
force-pushed
the
ck/param_set
branch
8 times, most recently
from
97de670
to
654976d
Compare
|
I think we've worked out most of the kinks. We'll come back to the reference state to address #98 later. |
charleskawczynski
force-pushed
the
ck/param_set
branch
from
654976d
to
aa071c7
Compare
Undo T_freeze changes Re-apply T_freeze mod, fix more constructors
charleskawczynski
force-pushed
the
ck/param_set
branch
from
aa071c7
to
575f049
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of Thermodynamics.jl to help construct the reference state profiles.