Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary support for OrthogonalSphericalShellGrid for MakieExt #3824

Merged
merged 9 commits into from
Oct 23, 2024
Merged

Temporary support for OrthogonalSphericalShellGrid for MakieExt #3824

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7a18bb0
Temporary support for OrthogonalSphericalShellGrid
glwagner Oct 5, 2024
078d7f0
Add link to Imaginocean
glwagner Oct 5, 2024
607e720
Update OceananigansMakieExt.jl
glwagner Oct 5, 2024
5482bba
Merge branch 'main' into glw/makie-ossg
glwagner Oct 7, 2024
eabecfc
Merge branch 'main' into glw/makie-ossg
glwagner Oct 8, 2024
e4a4ce2
Merge branch 'main' into glw/makie-ossg
glwagner Oct 17, 2024
69c381c
Merge branch 'main' into glw/makie-ossg
glwagner Oct 22, 2024
25190c9
Merge branch 'main' into glw/makie-ossg
glwagner Oct 23, 2024
075e8ef
Merge branch 'main' into glw/makie-ossg
glwagner Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ext/OceananigansMakieExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module OceananigansMakieExt

using Oceananigans
using Oceananigans.Grids: OrthogonalSphericalShellGrid
using Oceananigans.AbstractOperations: AbstractOperation
using Oceananigans.Architectures: on_architecture
using Oceananigans.ImmersedBoundaries: mask_immersed_field!
Expand Down Expand Up @@ -123,6 +124,13 @@ function convert_field_argument(f::Field)
end
end

# For Fields on OrthogonalSphericalShellGrid, just return the interior without coordinates
# TODO: support plotting in geographic coordinates using mesh
# See for example
# https://github.com/navidcy/Imaginocean.jl/blob/f5cc5f27dd2e99e0af490e8dca5a53daf6837ead/src/Imaginocean.jl#L259
const OSSGField = Field{<:Any, <:Any, <:Any, <:Any, <:OrthogonalSphericalShellGrid}
convert_field_argument(f::OSSGField) = make_plottable_array(f)

#####
##### When nodes are provided
#####
Expand Down