Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary support for OrthogonalSphericalShellGrid for MakieExt #3824

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Oct 5, 2024

This is a placeholder until we can use mesh to reinterpret heatmap in geographic coordinates, like ImaginOcean does. Otherwise, plotting fields on OrthogonalSphericalShellGrid fails because the coordinate vectors are not 1D.

@glwagner glwagner requested a review from navidcy October 5, 2024 14:54
@glwagner
Copy link
Member Author

glwagner commented Oct 5, 2024

Here's how Imaginocean does it:

https://github.com/navidcy/Imaginocean.jl/blob/f5cc5f27dd2e99e0af490e8dca5a53daf6837ead/src/Imaginocean.jl#L259

I think it could be fun to make that code run under the hood for any heatmap

@navidcy navidcy changed the title Temporary support for OrthogonalSphericalShellGrid Temporary support for OrthogonalSphericalShellGrid for MakieExt Oct 5, 2024
@glwagner glwagner merged commit 03b8acf into main Oct 23, 2024
46 checks passed
@glwagner glwagner deleted the glw/makie-ossg branch October 23, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants