Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean density must be referred to as a reference density #43

Open
glwagner opened this issue Nov 4, 2020 · 2 comments
Open

Ocean density must be referred to as a reference density #43

glwagner opened this issue Nov 4, 2020 · 2 comments

Comments

@glwagner
Copy link
Member

glwagner commented Nov 4, 2020

For detail-oriented folks, the variable

https://github.com/CliMA/CLIMAParameters.jl/blob/f779db6fa86f0bfce9de4ee31757fed1fe8b75ed/src/Planet/planet_parameters.jl#L36

is somewhat stressful, as the ocean density is not constant.

This quantity is really a reference density that must be defined as part of the Boussinesq approximation; it's important to identify it as a "reference" (and therefore a parameter) rather than an absolute value.

It's appropriate to include this parameter here, because it ends up appearing in a few unrelated places in ocean codes (and also user's scripts). But I think it should be called ocean_reference_density so as to not cause unwarranted stress for users that want to carefully manage their science.

@charleskawczynski
Copy link
Member

Sounds like a good idea. In the atmosphere, we append ref (e.g., T_min_ref) to indicate reference values.

@glwagner
Copy link
Member Author

glwagner commented Nov 4, 2020

For sure. That can work for mathematical notation form. Going along with #41 I think we should use the literal word reference to indicate reference values for English variable names.

bors bot added a commit that referenced this issue Jul 27, 2021
51: Add some planet parameters r=charleskawczynski a=charleskawczynski

These parameters are from "Large-eddy simulation in an anelastic framework with closed water and entropy balances" (Pressel et. al.), Table 1. This is needed for [TurbulenceConvection.jl's #43](CliMA/TurbulenceConvection.jl#43).

Co-authored-by: Charles Kawczynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants