Add some planet parameters #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 84.93% 83.43% -1.51%
==========================================
Files 7 7
Lines 166 169 +3
==========================================
Hits 141 141
- Misses 25 28 +3
Continue to review full report at Codecov.
|
charleskawczynski
force-pushed
the
ck/more_params
branch
from
6b7e6b2
to
9d1b709
Compare
tapios
reviewed
Jul 27, 2021
tapios
reviewed
Jul 27, 2021
tapios
approved these changes
Jul 27, 2021
|
Thanks for the review! |
Update src/Planet/Planet.jl Co-authored-by: Tapio Schneider <[email protected]> Update src/Planet/Planet.jl Co-authored-by: Tapio Schneider <[email protected]> Apply suggestions everywhere
charleskawczynski
force-pushed
the
ck/more_params
branch
from
47be2e5
to
5bbc0c1
Compare
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Aug 4, 2021
52: Remove duplicate function r=charleskawczynski a=charleskawczynski I accidentally added a duplicate function stub in #51 (which results in a documentation warning). This PR removes that duplicate function stub & doc string. Co-authored-by: Charles Kawczynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters are from "Large-eddy simulation in an anelastic framework with closed water and entropy balances" (Pressel et. al.), Table 1. This is needed for TurbulenceConvection.jl's #43.