Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alphabetize names, standardize symbols for parametric types #907

Closed
wants to merge 2 commits into from

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Nov 1, 2024

Purpose

Addresses a comment from review of PR #834

To-do

This is currently failing because it switches the order so that the canopy model updates aux, boundary fluxes, etc first. However, in global runs, the soil albedo is updated in the soil cache in soil update aux. and therefore it is not available to the canopy (still set to zero, un-initialized) and this leads to NaNs (there is a divide by alpha_soil in the canopy two stream).

This is a bigger issue because the soil albedo needs to be the same everywhere it is used within a timestep to conserve energy.

We need to move the canopy RT (and therefore also GPP...etc) to update boundary fluxes, I think?

Content

Alphabetizes the fields of the integrated land models, and uses the same symbols for their parametric types


  • I have read and checked the items on the review checklist.

@kmdeck kmdeck force-pushed the kd/alphabetize_land_components branch from 8d951a8 to bb80b8e Compare November 4, 2024 17:19
@kmdeck
Copy link
Member Author

kmdeck commented Nov 14, 2024

Closing for now, see Issue #919

@kmdeck kmdeck closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants