Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of operations in update aux #919

Open
kmdeck opened this issue Nov 14, 2024 · 0 comments
Open

Order of operations in update aux #919

kmdeck opened this issue Nov 14, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@kmdeck
Copy link
Member

kmdeck commented Nov 14, 2024

Describe the bug

The land model creates anupdate_aux! function which calls update_aux! of the component models in turn. This should be independent of the order of the component models.

Currently, if we switch canopy to update before soil, we get errors in canopy radiation because of soil albedo, which is updated in soil's update aux. Since canopy radiation depends on soil albedo, it should be in update_boundary_fluxes instead.

More broadly, we should rename these functions so that they clarify their role: update_independent_cache and update_dependent_cache? Should we remove the name aux entirely?

Come back to this when we have sussed out what these roles are ^^
@juliasloan25

To Reproduce

Check out PR#907

@kmdeck kmdeck added the bug Something isn't working label Nov 14, 2024
@kmdeck kmdeck self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant