Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove t_start from diagnostics #3287

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Remove t_start from diagnostics #3287

merged 2 commits into from
Sep 11, 2024

Commits on Sep 10, 2024

  1. Remove t_start 

    The diagnostic module was using `t_start`, but this was under the wrong
assumption.

I was under the impression that integrator.t restarts from 0 upon
restart, so that we needed to manually offset the time.

I think I got this idea from ClimaLand, where t_start is used often.

Using t_start was (probably) leading to incorrect dates being written in
NetCDF files when the simulation was restarted.
    @Sbozzolo
    Sbozzolo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ff49192 View commit details
    Browse the repository at this point in the history

  2. Rename reference_date to start_date

    @Sbozzolo
    Sbozzolo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a2644aa View commit details
    Browse the repository at this point in the history