Remove t_start from diagnostics #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/remove_tstart
branch
from
937def9
to
235dd3c
Compare
The diagnostic module was using `t_start`, but this was under the wrong assumption. I was under the impression that integrator.t restarts from 0 upon restart, so that we needed to manually offset the time. I think I got this idea from ClimaLand, where t_start is used often. Using t_start was (probably) leading to incorrect dates being written in NetCDF files when the simulation was restarted.
Sbozzolo
force-pushed
the
gb/remove_tstart
branch
from
235dd3c
to
ff49192
Compare
Sbozzolo
force-pushed
the
gb/remove_tstart
branch
from
27f9323
to
a2644aa
Compare
szy21
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostic module was using
t_start, but this was under the wrong assumption.I was under the impression that integrator.t restarts from 0 upon restart, so that we needed to manually offset the time.
I think I got this (wrong) idea from ClimaLand, where t_start is used often.
Using t_start was (probably) leading to incorrect dates being written in NetCDF files when the simulation was restarted.