Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete (empty) src/mission_end.cpp #73088

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Brambor
Copy link
Contributor

@Brambor Brambor commented Apr 17, 2024

Summary

None

Purpose of change

^Made this file empty, but didn't delete it. I don't know why. There is no reason to have an empty .cpp file.

Describe the solution

rm

Describe alternatives you've considered

Testing

I searched for occurrences of misson_end if it were required for some black magic. GitHub tests will show it still compiles.

Additional context

I was looking through my old PRs. I removed some includes in that file in #71141. Like the author of #62589, I didn't delete the empty .cpp file either.

@github-actions github-actions bot added Missions Quests and missions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 17, 2024
@Maleclypse Maleclypse merged commit 3577b05 into CleverRaven:master Apr 18, 2024
24 of 28 checks passed
@Brambor Brambor deleted the del-mission-end branch April 18, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants