Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the "Retrieve Deposit Box" mission to JSON format #62589

Merged
merged 11 commits into from
Jan 9, 2023
Merged

Migrate the "Retrieve Deposit Box" mission to JSON format #62589

merged 11 commits into from
Jan 9, 2023

Conversation

MNG-cataclysm
Copy link
Contributor

Summary

Infrastructure "Move the Retrieve Deposit Box mission to JSON format"

Purpose of change

Move the missions reliant on C++ functions to a more accessible JSON format.

Describe the solution

I removed the C++ functions and replaced them with JSON.

Describe alternatives you've considered

Leaving it as is.

Testing

I took the mission, went to the bank, stole the deposit box, and returned it to its rightful owner.

Additional context

None.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON EOC: Effects On Condition Anything concerning Effects On Condition Missions Quests and missions Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 5, 2022
@MNG-cataclysm MNG-cataclysm changed the title Migrate the "Retrieve Deposit Box" to JSON format Migrate the "Retrieve Deposit Box" mission to JSON format Dec 6, 2022
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 12, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 12, 2022
@MNG-cataclysm
Copy link
Contributor Author

@Maleclypse Could you remove the string freeze label, please?

@dseguin dseguin merged commit 8f1a874 into CleverRaven:master Jan 9, 2023
@MNG-cataclysm MNG-cataclysm deleted the deposit_box_jsonify branch January 12, 2023 15:44
@Brambor Brambor mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse approved these changes

@cathalpern cathalpern cathalpern approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MNG-cataclysm @cathalpern @Maleclypse @Night-Pryanik @dseguin