-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toxic waste map extra #59618
Add toxic waste map extra #59618
Conversation
Co-authored-by: chaohedgehogs <[email protected]>
Co-authored-by: chaohedgehogs <[email protected]>
I rebased and yet this damn required test is still failing. Why? I do not see anything related to my PR in the test output, so I have the feeling it may just be one of those random failures again |
(╯°□°)╯︵ ┻━┻ The reason the test failed was because the survivor note in the same file, which I have not touched, had a "non-sensical item density" and I did a copy-from from it. Super annoying, I had to search for a fix for something I have not touched. |
I know I am being (literally, heh) pushy, but just a FYI that this is ready to merge unless someone objects due to balance reasons. |
Summary
Content "Add toxic waste map extra"
Purpose of change
Take 2 of #55211. This adds an illegal toxic waste dump where some random company dumped their trash, which includes chemicals. Rarely however, this company might be XEDRA...
Describe the solution
The map extra is basically a pool of sewage with normal or trashy rubble ontop with barrels containing mostly vile stuff scattered. There is an okay chance to get a small amount of some chemicals from the barrels. There is also a big variety of chemical spills, which are basically cosmetic only.
Furthermore, there are three "optional" features which the map extra may feature depending on how the RNG feels:
Describe alternatives you've considered
I am open to changing the chances of some stuff. I am also not 100% sure about the chemicals because I am a noob when it comes to that.
I also thought of adding empty and/or damaged atomic batteries and stuff like atomic lamps to the radioactive part.
Testing
Loads correctly, manually explored the world until I found a natural spawn.
Additional context
I might subject the non-illegal toxic waste dump to some love, too. So it is only radioactive when plutonium and stuff is being spawned.
Also, I think
liquids
does not work with item groups which is a shame really or copy-pasting the liquids into the toxic gas vent would not be necessary, if setting fields would not erase spilled liquids which is a bug I still have to report.