Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toxic waste map extra #59618

Merged
merged 7 commits into from
Aug 9, 2022
Merged

Conversation

NetSysFire
Copy link
Member

@NetSysFire NetSysFire commented Jul 26, 2022

Summary

Content "Add toxic waste map extra"

Purpose of change

Take 2 of #55211. This adds an illegal toxic waste dump where some random company dumped their trash, which includes chemicals. Rarely however, this company might be XEDRA...

image

Describe the solution

The map extra is basically a pool of sewage with normal or trashy rubble ontop with barrels containing mostly vile stuff scattered. There is an okay chance to get a small amount of some chemicals from the barrels. There is also a big variety of chemical spills, which are basically cosmetic only.

Furthermore, there are three "optional" features which the map extra may feature depending on how the RNG feels:

  • Radioactive waste (20% chance), to make it fairer and less surprising to the player it will have a broken fence around it and plutonium slurry.
  • Toxic gas vents (90% chance to have at least one of them).
  • Mutant corpses (10% chance to encounter at least one), lore-stuff: lab staff dumped them there and may also conveniently forget a note with vague clues where to find labs.

Describe alternatives you've considered

I am open to changing the chances of some stuff. I am also not 100% sure about the chemicals because I am a noob when it comes to that.

I also thought of adding empty and/or damaged atomic batteries and stuff like atomic lamps to the radioactive part.

Testing

Loads correctly, manually explored the world until I found a natural spawn.

Additional context

I might subject the non-illegal toxic waste dump to some love, too. So it is only radioactive when plutonium and stuff is being spawned.
Also, I think liquids does not work with item groups which is a shame really or copy-pasting the liquids into the toxic gas vent would not be necessary, if setting fields would not erase spilled liquids which is a bug I still have to report.

@NetSysFire NetSysFire added <Enhancement / Feature> New features, or enhancements on existing Map / Mapgen Overmap, Mapgen, Map extras, Map display Lore Game lore, in-game communication. Also the Lore tab. labels Jul 26, 2022
@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Jul 26, 2022
@NetSysFire NetSysFire requested a review from I-am-Erk July 26, 2022 00:34
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 26, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Jul 28, 2022
@NetSysFire
Copy link
Member Author

I rebased and yet this damn required test is still failing. Why? I do not see anything related to my PR in the test output, so I have the feeling it may just be one of those random failures again

@NetSysFire
Copy link
Member Author

(╯°□°)╯︵ ┻━┻

The reason the test failed was because the survivor note in the same file, which I have not touched, had a "non-sensical item density" and I did a copy-from from it. Super annoying, I had to search for a fix for something I have not touched.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 2, 2022
@NetSysFire
Copy link
Member Author

I know I am being (literally, heh) pushy, but just a FYI that this is ready to merge unless someone objects due to balance reasons.

@I-am-Erk I-am-Erk merged commit f80d2ee into CleverRaven:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants