Add 'Brawler' trait, disallowing use of ranged weapons

[tornikeo]

Summary

Content "Add 'Brawler' trait, disallowing ranged weapon use"

Purpose of change

Add a trait that acts as a wayfarer, but for ranged weapons. Characters with 'Brawler' trait can no longer wield any non-bionic ranged weapons (type 'GUN'). Fixes #47337.

Describe the solution

Add Brawler trait below wayfarer, in traits JSON. Add extra condition check in Character::can_wield where if item type is gun and char has the trait, the action is refused.

Describe alternatives you've considered

Allow gun wield, disallow firing. Buuut, I went in the analogy of the wayfarer. Which just disallows controlling vehicles, instead of allowing that and disallowing to move the vehicle.
Edit: I went with this alternative in the end. Wield guns, no pew-pew allowed. Also, no turret use.

Testing

Additional context

None

[lbnesquik]

This is an interesting trait. I think it could be added as is, honestly!

Here are some comments :

• Change 'guns' to 'ranged weapons' as the GUN category includes things like crossbows or longbows. That might catch some people off guard.

• Maybe allow non-modern weapons, such as bows or slings, perhaps as a second, less rewarding trait.

• Have you considered it being an extreme mood penalty instead of a strict lock?

[tornikeo]

Hey. Thanks. Here's what I think (please correct me as you see fit):

• Good point. On it.
• That would require me to create a list of all items that are bows and check for that. Also, crossbows having underbarrel attachments makes that incredibly difficult.
• I use established things as guides. I see that wayfarer doesn't have that kind of flexibility. That's why I went with this, alongside with the simplicity of implementing this.
  What are your thoughts?

[Inglonias]

I think a flat inability to wield these weapons works better than a mood penalty. A mood penalty would open the door to minmaxing. Considering this trait is optional, keep it as is. Plus, in combat, your mood really doesn't affect your performance too much.

[TheShadowFerret]

Why "no wielding" rather than "no firing?" I don't always have storage for long weapons(in this issue, long guns) that I want to sell, so I wield them on way to the trader.

[tornikeo]

That's a good point. I mean, not wanting to even touch ranged weapons during the cataclysm is as crazy as the wayfarer trait. But what you suggest might be better overall. I'll have to block a few key inputs then.

[tornikeo]

[tornikeo]

I need someone to give me the good ol' Torvalds-level criticism about my code here. Especially about removing vs disabling vehicle options.

[anoobindisguise]

What ranged abilities does this leave the player? Throwing rocks/grenades, bows/crossbows (?), bionic shotgun and finger laser (?). Guns are in a class of their own when it comes to ranged weapons but I don't know how comprehensive this is in total.

[snipercup]

What ranged abilities does this leave the player? Throwing rocks/grenades, bows/crossbows (?), bionic shotgun and finger laser (?). Guns are in a class of their own when it comes to ranged weapons but I don't know how comprehensive this is in total.

Also wands, possibly spells. It really depends on your definition of ranged weapon.

[tornikeo]

Whoa. Well, that's a lot of unnecessary labels (800 lines of code?!). I tried rebasing to 9d0c414 . Since that's the last successful commit (doesn't fail tests). Am I doing this wrong? :D
Update: Just had to rebase the last 3 commits. Instead did every commit since my last commit. I believe that's fixed now.

[anoobindisguise]

FWIW I thought that 4 points for Brawler was a pretty decent trade, I was theorycrafting and honestly couldn't decide if it was worth it or not because ranged weapons (guns especially) are extremely valuable assets but I have managed to make do without them on strong melee characters. However even those would sometimes want to use a gun for a smoker or something. At two points though I couldn't see myself ever taking that trait if I wanted a "strong" character.

[tornikeo]

@anoobindisguise Hey. My thoughts exactly. Think about it like this: Can a wayfarer ever beat a guy with death APC? No way right? This trait is for people who played with guns too often and want to find other ways of playing the game. Me included - for me, the game is "won" whenever I find an M4. From that I snowball to a scar-h and, finally, Barrett - the ultimate door-buster. With this trait, you won't ever get those - the question is, can you adapt around this crippling restriction?

p.s.: The point gain will be tweaked if a reasonable number of you guys want it - I'll do it myself, even. :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[waveyl]

Is this on purpose?