Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition nutrition to kcal for good #56728

Merged
merged 5 commits into from
Apr 11, 2022

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Apr 10, 2022

Summary

None

Purpose of change

Fixes #45720

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 10, 2022
@github-actions github-actions bot added the <Documentation> Design documents, internal info, guides and help. label Apr 10, 2022
@Maleclypse
Copy link
Member

I think explicitly changing the name from hunger to kcal would make it clearer what is being impacted.

@Fris0uman Fris0uman marked this pull request as ready for review April 10, 2022 16:57
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 10, 2022
@kevingranade kevingranade merged commit 666fb27 into CleverRaven:master Apr 11, 2022
@Fris0uman Fris0uman deleted the nutrition branch April 11, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition nutrition to kcal for good
3 participants