Transition nutrition to kcal for good

[Fris0uman]

Is your feature request related to a problem? Please describe.

Cataclysm-DDA/src/character.cpp

Lines 4989 to 4993 in 90cab7a

	void Character::mod_stored_nutr( int nnutr )
	{
	// nutr is legacy type code, this function simply converts old nutrition to new kcal
	mod_stored_kcal( -1 * std::round( nnutr * 2500.0f / ( 12 * 24 ) ) );
	}

Internally mod_stored_nutr() converts nutrition number to kcal before apllying the modification, but it means that values used in json, like the cost entry of mutation are still in nutrition instead of kcal it also means that each time the code calls mod_stored_nutr() it has to use nutrition value to avoid conveting twice.

Describe the solution you'd like

Change all json value and internal value to kcal and remvoe the convertion from mod_stored_nutr()

Describe alternatives you've considered

Maybe introduced cal as a unit

Additional context

This is not high priority but I think it will make the code easier to maintain.

[Xaleth]

Or not convert to kcal at all and just display calories. Going through around a thousand different foods to change to kcal is imo a bit excessive for something so trivial.

[anothersimulacrum]

We already use kcal for all our food??

[Fris0uman]

Maybe food is in kcal, but from that snippet of code not everything is yet.

[Xaleth]

What if you just have kcal and cal as options in the world menu?

Why can't there be both?

[KorGgenT]

i believe there are only a very small number of things that use nutrition, so it should be fairly painless to transition. i don't believe there is a single example of json that's using "nutrition" instead of calories.

[Fris0uman]

Any mutation that uses "hunger" as a cost is using nutrition, I don't know how many that is though.