Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with t-shirt variants in professions #56290

Merged
merged 10 commits into from
Mar 27, 2022
Merged

Fix problems with t-shirt variants in professions #56290

merged 10 commits into from
Mar 27, 2022

Conversation

Meandering-Breviger
Copy link
Contributor

@Meandering-Breviger Meandering-Breviger commented Mar 21, 2022

Summary

Bugfixes "Generic t-shirts in professions & a t-shirt variant"

Purpose of change

Describe the solution

  • Went around and added a { "item": "tshirt", "variant": "generic_tshirt" } to every profession with a t-shirt (did base game, Magiclysm, Bionic Professions).
  • Added a t-shirt variant "Down with Swordocracy"

Describe alternatives you've considered

none

Testing

Compiled (Linux Tiles). Went and started a character made sure #56272 was fixed. Then went and made sure Swordocracy spawned in.

Additional context

Think I got all the professions that use t-shirts including mods.
This is more of a quick fix to the problem. Eventually someone will need to add a variant selection menu as said by anothersimulacrum and ZhilkinSerg over on the issue.

@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Mar 21, 2022
@Meandering-Breviger Meandering-Breviger changed the title T shirt patch T-shirt patch Mar 21, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 21, 2022
@Meandering-Breviger Meandering-Breviger changed the title T-shirt patch Fix problems with t-shirt variants in professions Mar 21, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 21, 2022
@github-actions github-actions bot added Mods: Magiclysm Anything to do with the Magiclysm mod and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 21, 2022
@Meandering-Breviger Meandering-Breviger marked this pull request as ready for review March 22, 2022 00:42
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 22, 2022
@kevingranade kevingranade merged commit 21bebf8 into CleverRaven:master Mar 27, 2022
@Meandering-Breviger Meandering-Breviger deleted the t-shirt-patch branch March 27, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially undesired issues with t-shirts?
2 participants