Potentially undesired issues with t-shirts?

[Meandering-Breviger]

Describe the bug

See this video for clarity (on reddit since it's easier).
If you watch the video you will notice the obvious, the game can't decide on what t-shirt to use and switches between the new variants added in #56041 upon every arrow key press.
Perhaps #56041 can be moved to tshirt_text or have tshirt_text be merged into tshirt as its kinda redundant by this point?

Steps to reproduce

• Start up character creator
• Go to professions
• Look for something with a t-shirt like Science Club Member
• Hit the left and right arrow keys.

Expected behavior

Kinda expected nothing would change and it just be a generic t-shirt.

Screenshots

No response

Versions and configuration

• Linux Tiles
• Experimental as of 3/20/22

Additional context

No response

[NetSysFire]

Ping @Maleclypse

[Maleclypse]

It might be possible to fix it by changing the character creation menu to use a specific t-shirt variant. I believe there is still a genericized variant t-shirt that could be used for this. If that's the case then this could be fixed with JSON only I think.

[Meandering-Breviger]

You're right Maleclypse tis a json thing. Every instance where a generic tshirt is wanted (of which there are 29) (edit: There's more...) is now going to need one of these.

      "entries": [
          {"item": "tshirt", "variant": "generic_tshirt"}
      ]
    },

I'll do a pr for this soonish.

[anothersimulacrum]

We probably need a C++ solution to this in the future (only select variants once).

[ZhilkinSerg]

UI should probably allow to select item variants, but selecting random variant (as it does now) is also fine if it would be selected only once.