-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More variants phone cases and t-shirts #56041
Merged
ZhilkinSerg
merged 6 commits into
CleverRaven:master
from
Maleclypse:Variant-cell-phone-cases
Mar 20, 2022
Merged
More variants phone cases and t-shirts #56041
ZhilkinSerg
merged 6 commits into
CleverRaven:master
from
Maleclypse:Variant-cell-phone-cases
Mar 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maleclypse
added
[JSON]
Changes (can be) made in JSON
Items / Item Actions / Item Qualities
Items and how they work and interact
labels
Mar 11, 2022
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Mar 11, 2022
How about "I survived the apocalypse and all I got was this lousy T-shirt?". If you need inspiration, nethack has t-shirts, too: |
Update containers.json Update torso_clothes.json Co-Authored-By: TheShadowFerret <[email protected]>
Maleclypse
force-pushed
the
Variant-cell-phone-cases
branch
from
March 11, 2022 23:28
2f7e870
to
0cd5fb9
Compare
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Mar 11, 2022
Maleclypse
force-pushed
the
Variant-cell-phone-cases
branch
from
March 11, 2022 23:57
0c2dfc3
to
f4a825b
Compare
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Mar 11, 2022
Maleclypse
commented
Mar 12, 2022
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Mar 12, 2022
haveric
reviewed
Mar 13, 2022
Update torso_clothes.json Update torso_clothes.json Update torso_clothes.json Update data/json/items/armor/torso_clothes.json Update torso_clothes.json fixes
Maleclypse
force-pushed
the
Variant-cell-phone-cases
branch
from
March 14, 2022 02:43
c642384
to
aea9a4c
Compare
github-actions
bot
removed
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 14, 2022
haveric
reviewed
Mar 14, 2022
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 14, 2022
Qrox
reviewed
Mar 16, 2022
Maleclypse
commented
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items / Item Actions / Item Qualities
Items and how they work and interact
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
I'm probably going to add a bunch of variants this weekend.
Describe the solution
Adds more variants. Where will it stop?
Describe alternatives you've considered
Never
Testing
they appear
Additional context