Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More variants phone cases and t-shirts #56041

Merged
merged 6 commits into from
Mar 20, 2022

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Mar 11, 2022

Summary

None

Purpose of change

I'm probably going to add a bunch of variants this weekend.

Describe the solution

Adds more variants. Where will it stop?

Describe alternatives you've considered

Never

Testing

they appear

Additional context

@Maleclypse Maleclypse added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Mar 11, 2022
@Maleclypse Maleclypse marked this pull request as draft March 11, 2022 21:28
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 11, 2022
@NetSysFire
Copy link
Member

How about "I survived the apocalypse and all I got was this lousy T-shirt?". If you need inspiration, nethack has t-shirts, too:

https://github.com/NetHack/NetHack/blob/e83917bbf3b6d351d15fb3f692226652632d6d67/src/read.c#L102

Update containers.json

Update torso_clothes.json

Co-Authored-By: TheShadowFerret <[email protected]>
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Mar 11, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 11, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 12, 2022
@Maleclypse Maleclypse marked this pull request as ready for review March 14, 2022 01:32
@Maleclypse Maleclypse marked this pull request as draft March 14, 2022 01:33
Update torso_clothes.json

Update torso_clothes.json

Update torso_clothes.json

Update data/json/items/armor/torso_clothes.json

Update torso_clothes.json

fixes
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 14, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 14, 2022
data/json/items/containers.json Outdated Show resolved Hide resolved
data/json/items/containers.json Outdated Show resolved Hide resolved
data/json/items/containers.json Outdated Show resolved Hide resolved
data/json/items/containers.json Outdated Show resolved Hide resolved
@Maleclypse Maleclypse marked this pull request as ready for review March 18, 2022 03:13
@ZhilkinSerg ZhilkinSerg merged commit 14b4f11 into CleverRaven:master Mar 20, 2022
@Maleclypse Maleclypse deleted the Variant-cell-phone-cases branch September 24, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants