Fix missing appliance removal prompt #56189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Maleclypse
added
the
Appliance/Power Grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes an oversight from #55583, where the requirements for removing an appliance are not communicated to the player.
Describe the solution
Fix the hammerspace check, which always evaluated to true (oops). Also replaces the skill check with a list of missing requirements:
Describe alternatives you've considered
Getting rid of removal requirements altogether (they're defined in JSON, so they could just be removed there).
Testing
See screenshot above. Using a wrench makes the removal successful.
Additional context