Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to take down appliances #55583

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented Feb 22, 2022

Summary

None

Purpose of change

Fixes #54576.
Appliances are currently impossible to remove once installed (other than smashing).

Describe the solution

Add an option to the appliance UI:

2022-02-21.22-38-37.mp4

Describe alternatives you've considered

Adding a removal option to the construction menu, although it might be more intuitive to do it from the appliance UI.

Testing

TODO:

  • Plain empty appliance
  • Non-empty appliance
  • Appliance with multiple parts installed
  • Wall wiring

Additional context

Follow up to #53884.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 22, 2022
@NetSysFire NetSysFire added [C++] Changes (can be) made in C++. Previously named `Code` Appliance/Power Grid Anything to do with appliances and power grid labels Feb 22, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 22, 2022
@Fris0uman
Copy link
Contributor

What happens when you remove wall wiring? Since they are free to spawn they proably shouldn't drop anything when you remove it

@dseguin
Copy link
Member Author

dseguin commented Feb 22, 2022

What happens when you remove wall wiring? Since they are free to spawn they proably shouldn't drop anything when you remove it

That was my thought as well, I made it so that they don't return their base item on removal. It's more of a "cover up wiring" option

@dseguin dseguin marked this pull request as ready for review February 22, 2022 20:31
@kevingranade kevingranade merged commit 1bee9b2 into CleverRaven:master Feb 25, 2022
@dseguin dseguin deleted the app_remove_option branch February 26, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power Grid/Appliances need removal options
4 participants