Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix to TRANSLATING guide #56075

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Minor fix to TRANSLATING guide #56075

merged 2 commits into from
Mar 15, 2022

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Fix some inconsistencies with translation guide.

Describe the solution

Do minor changes to the file:

  • Game uses a modified gettext now.
  • There are now 50k+ strings (with mods), so marked that.
  • You can switch language in game now, so noted that.
  • Minor fix to Cataclysm not being uppercase.

Describe alternatives you've considered

  • Add instruction on how to download an up to date .po file from Transifex.
  • Strictly enforce 80-character limit in file (there are places where the lines are way longer, guess no one really cares nowadays)
  • Remove the part that you can switch the languages by replacing files, since there's an option to switch language in the game directly.

Testing

None, it doesn't show anywhere in game AFAIK.

Additional context

@Faalagorn
Minor fix to TRANSLATING guide
4e5cd5d 
* Game uses a modified gettext now.
* There are now 50k+ strings (with mods), so marked that.
* You can switch language in game now, so noted that.
* Minor fix to Cataclysm not being uppercase.
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 13, 2022
haveric
haveric reviewed Mar 13, 2022
View reviewed changes
doc/TRANSLATING.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 13, 2022
@Rivet-the-Zombie Rivet-the-Zombie merged commit d703f84 into CleverRaven:master Mar 15, 2022
@Faalagorn Faalagorn deleted the patch-4 branch March 15, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haveric haveric haveric left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Faalagorn @haveric @Rivet-the-Zombie