-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stocks, stock accessories, new C++ handling for Folding Stocks #55802
Conversation
That sign won't stop me because I can't read! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked missing apostrophes
"id": "FOLDED_STOCK", | ||
"//": "for weapons that stock folds to one side, no change in volume.", | ||
"type": "json_flag", | ||
"info": "This items stock is folded it will be hard to shoot with." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
items → item's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing comma before "it" (or better yet, ", so it")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also give tag as well while at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally (sorry about the comment streak); "item" or "gun"? I think there's no other items that can have stocks.
"id": "COLLAPSED_STOCK", | ||
"//": "for weapons that stock collapses into the body reducing volume as well.", | ||
"type": "json_flag", | ||
"info": "This items stock is collapsed it will be hard to shoot with." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
items → item's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing comma before "it" (same as above)
Summary
Content "Folding Stocks that fold on activate, Stock accessories"
Purpose of change
#55428 back-end implementation stuff. Plus the part I want which is functioning folding stocks.
Describe the solution
This PR does the following:
Specifically:
Describe alternatives you've considered
Adding dispersion changes as well, however this isn't currently handled in game and I didn't want to scope creep anymore.
Adding rules for buffer tube rifles.
Testing
Everything works in game as far as I can see. Gonna get yelled at by generic guns.
Additional context
Collapsed Vs Noncollapsed
Folded Vs Nonfolded
Accessories on a gun