Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible vehicle parts list #52469

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented Oct 26, 2021

Summary

None

Purpose of change

Fixes #52447.
There was a small bug introduced by #51286, where only appliances were displayed in the vehicle parts installation list.

Describe the solution

Based on the original PR, appliances should probably only be installed via the construction menu. This change reverses visibility of items in the parts list, so that only non-appliance parts (aka basically all of them) are listed for installation in vehicles.

Describe alternatives you've considered

Allowing all parts including appliances to be installed in vehicles, although this would make the appliance unusable.

Testing

  1. Spawn a car
  2. 'e'xamine the car and try to install a part
  3. Browse the non-invisible parts list

To make sure appliances still work:

  1. Spawn a fridge item
  2. Use the '*' construction menu to "place fridge"
  3. 'e'xamine the placed fridge and plug the power cord into a nearby vehicle
  4. Turn on the fridge

Additional context

@dseguin dseguin changed the title Display non-appliances in vehicle parts list Fix invisible vehicle parts list Oct 26, 2021
@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Vehicles Vehicles, parts, mechanics & interactions labels Oct 27, 2021
@ZhilkinSerg ZhilkinSerg merged commit bdf59dd into CleverRaven:master Oct 27, 2021
@dseguin dseguin deleted the fix_veh_list branch November 7, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Part list is almost fully invisible when attempting to install a vehicle part
3 participants