-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Appliance implementation #51286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 1 alert when merging 626ba27 into c11072c - view on LGTM.com new alerts:
|
actual-nh
added
<Enhancement / Feature>
New features, or enhancements on existing
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Vehicles
Vehicles, parts, mechanics & interactions
labels
Sep 1, 2021
I don't understand the description (or, rather, my attempts to do so results in unreasonable functionality):
|
None of the data in the zip file is meant to go in the game, this is a quick json edit to get things to instal and try
|
Fris0uman
changed the title
Basic power grid implementation
[CR] Basic power grid implementation
Sep 3, 2021
Fris0uman
force-pushed
the
appliance
branch
2 times, most recently
from
September 9, 2021 09:21
9043453
to
1988e09
Compare
Fris0uman
changed the title
[CR] Basic power grid implementation
[CR] Basic Appliance implementation
Sep 9, 2021
Fris0uman
force-pushed
the
appliance
branch
2 times, most recently
from
September 11, 2021 17:03
cdc506a
to
70a5de3
Compare
Fris0uman
changed the title
[CR] Basic Appliance implementation
Basic Appliance implementation
Oct 10, 2021
This was referenced Oct 26, 2021
UmbralReaper
added a commit
to UmbralReaper/Cataclysm-DDA
that referenced
this pull request
Jan 13, 2022
With the tailoring overhaul currently in progess in CleverRaven#54256, as well as appliances being introduced in CleverRaven#51286, I figured this was the best time to add sewing machines to cause the least amount of churn. works towards CleverRaven#53647
dseguin
added
the
Appliance/Power Grid
Anything to do with appliances and power grid
label
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Appliance/Power Grid
Anything to do with appliances and power grid
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
<Enhancement / Feature>
New features, or enhancements on existing
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Vehicles
Vehicles, parts, mechanics & interactions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Basic Appliance implementation"
Purpose of change
Does this #28289
Describe the solution
APPLIANCE
flagAPPLIANCE
parts on normal vehiclesAPPLIANCE
is an appliance- You can plug into an infinity of other vehicle
- the power cord can't be uninstalled and doesn't drop when the vehicle is destroyed or move away, but it does disconnect
Describe alternatives you've considered
Testing
Spawn a fridge item
Place fridge
Plug fridge into a nearby vehicle with battery power
Turn fridge on
Wait a few hours
Vehicle battery is properly depleted
Grab appliance
Try to move
"The fridge collides with ."
So collision for appliance is bugged but I have no idea how to fix it
Additional context
This only add the infrastructure and the json for the fridge.
What's missing and should happen in other PRs: