[Blaze] Move recipes for Blaze vehicle crafting rigs from Aftershock to Blaze. #48373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shacknetisp
requested review from
John-Candlebury,
Maleclypse and
Mom-Bun
as code owners
BrettDong
added
Mods
Mom-Bun
approved these changes
Apr 5, 2021
|
Those three things are missing from my game. I wasn't able to find the recipe and I wasted a lot of time to look for it. My friends also ensured this with his game and came with same result. DID YOU REALLY TESTED? I just removed the three recipes in data/mods/Aftershock/recipes/obsolete.json and the recipes are existant in game again. |
|
I am not very familiar with the code here. If the obsolete recipes should not have been added, would you please submit a PR to fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Move recipes for Blaze vehicle crafting rigs from Aftershock to Blaze."
Purpose of change
#47279 moved vehicle parts including the metal, kitchen, and cooking crafting rigs from Aftershock to Blaze, but did not move the recipes, so they remain uncraftable unless Aftershock is also loaded.
Describe the solution
This PR moves the recipes from Aftershock to Blaze Industries, replacing with obsolete recipes in Aftershock.
Testing
Load a world with Blaze Industries and no Aftershock and gain all recipes; the MetalMaster forge buddy, KitchenMaster cooking buddy, and cooking rig will only be craftable with this PR.