-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Aftershock] Move non scifi vehicle parts to Blaze Industries #47279
[Aftershock] Move non scifi vehicle parts to Blaze Industries #47279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this was needed!
Just to note: Please obsolete trailer vehicles with this; if you can? It doesn't fit aftershock, and should indirectly solve #45701
You can move it to Blazemod; but considering the current bugged implementation, might not be a good idea until C++ support gets added for trailers; and trailers should be vanilla anyhow.
Also thoughts on adding the bubble car to this? Afaik the only sci-fi thing about it is the nuclear reactor; and that is it, its just a regular weird looking car.
I have no problem with bubble car and the other atomic vehicles staying in. |
No No; I'm fine with the other atomic cars as those are sci-fi, its just the bubble car is just a bit... random? Like Its a weird curvy car that exists and randomly has atomic reactor for... no reason? It is apparently modeled after a real concept car from the 1990s; and it had no nuclear reactor in it. |
The trailers were in the vehicle override file so I'm wondering if the trailers exist in vanilla but I'm not interested in checking :). I've deleted them entirely. |
…CleverRaven#47279)" I never intended for this to happen.
Summary
Mods "Vehicle parts from AFS to Blaze"
Purpose of change
I have had this move of non sci fi vehicle parts to Blaze on my to do list for most of a year.
Describe the solution
Moves json from AFS to Blaze and creates obsoletes in AFS for people that don't use Blaze.
Describe alternatives you've considered
Solely obsoleting them.
Testing
TBD
Additional context