-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relic activation ability #42391
Add relic activation ability #42391
Conversation
This is an excellent start! I want these things for the procgen in order to be as flexible as possible:
I believe all of these features will make for very well-rounded procedural generation rules for artifacts. |
edb6969
to
1ad4b25
Compare
Encapsulate all the charge info about relics in a relic_charge_info struct. Additionally, add a template struct, and allow using this to specify variants of relic charge info in relic_procgen_data. Add simple placeholder versions to this data, along with active effects for it to provide. Attempt to recharge relics when processing them.
1ad4b25
to
a30ac67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only thing i encountered upon generating an artifact.
The other thing i mentioned on discord (artifacts not showing up in the a
menu) imo could/should be a follow up PR and not block this PR from merging.
Summary
SUMMARY: Features "Add activation abilities and charges to relics"
Purpose of change
Requested by @KorGgenT to further obsolete the artifact code.
Describe the solution
Encapsulate all the charge info about relics in a relic_charge_info struct - then allow specifying variations of this in the relic_procgen_data.
Add simple placeholder versions to this data, along with active effects for it to provide.
Attempt to recharge relics when processing them.
Testing
Spawn in a relic, activate it. See that it gives you pain. Wait for more than 6 hours, see that the relic has recharged.
Additional context