Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #40225 #40344

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

RoyBerube
Copy link
Contributor

@RoyBerube RoyBerube commented May 8, 2020

Summary

SUMMARY: Bugfixes "Fix of engorging on infinite source of food or water."

Purpose of change

Fixes #40225. Drinking from any infinite source of water such as a water dispenser would bypass the consequence check and allow the player to over consume without feedback.

Describe the solution

Changed the condition check to handle any input source amount with slightly altered logic.

Describe alternatives you've considered

Testing

Spawned in terrain with water dispenser. Drank from it with no consequence message until engorged. Any subsequent drink triggered the consequence check, and eventually vomit.

Also tested with drinking from a container and with food. All triggered the consequence check once engorged.

Additional context

Attempt to engorge on infinite source properly triggers consequence check.
@ZhilkinSerg ZhilkinSerg merged commit 92731b4 into CleverRaven:master May 8, 2020
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Character / Player Character / Player mechanics labels May 8, 2020
@RoyBerube RoyBerube deleted the engorge-on-infinite branch May 8, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consuming from Water Dispenser doesn't check for fullness
2 participants