Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mod test blacklist for removed mods #40338

Merged
merged 3 commits into from
May 9, 2020

Conversation

anothersimulacrum
Copy link
Member

Summary

SUMMARY: None

Purpose of change

Update blacklist after #40325, #40326, #40327, #40329, #40330, #40332, #40333, #40334, #40335, #40336, #40337

Describe the solution

Remove all mods that no longer exist from the blacklist

Describe alternatives you've considered

As with all those PRs above, waiting longer.

Additional context

Please hold off merging this until all those PRs are merged.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Organization General development organization issues labels May 8, 2020
@kevingranade
Copy link
Member

A handful of failures:

src/assign.h:796 [bool assign(const JsonObject &, const std::string &, damage_instance &, bool, const damage_instance &, const damage_instance &)] Warning: ichaival_replica loads damage using legacy methods - damage type may be wrong

06:48:46.711 ERROR : src/mongroup.cpp:313 [static void MonsterGroupManager::FinalizeMonsterGroups()] monster on blacklist mon_zombie_grenadier does not exist

06:48:46.711 ERROR : src/mongroup.cpp:313 [static void MonsterGroupManager::FinalizeMonsterGroups()] monster on blacklist mon_zombie_grenadier_elite does not exist

@ZhilkinSerg ZhilkinSerg merged commit 666e274 into CleverRaven:master May 9, 2020
@anothersimulacrum anothersimulacrum deleted the update-blacklist branch May 9, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Organization General development organization issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants