Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pocket data to all magazines #40295

Merged
merged 2 commits into from
May 10, 2020
Merged

Conversation

ymber
Copy link
Member

@ymber ymber commented May 7, 2020

Summary

SUMMARY: Infrastructure "Add pocket data to all magazines"

Purpose of change

Puts data in place to start cutting old code.

Describe the solution

Add pocket data to all magazine type items. This data can replace the type and capacity members of islot_magazine going forward.

Testing

Game loads, magazines still work.

@ymber ymber added [JSON] Changes (can be) made in JSON Items: Magazines Ammo holding items and objects. [Python] Code made in Python labels May 7, 2020
@ymber ymber requested a review from KorGgenT as a code owner May 7, 2020 16:47
@Inglonias
Copy link
Contributor

If you're converting magazines to pockets, does that mean you can load things into them that aren't bullets? Do guns check to make sure that the things loaded into magazines are bullets?

@KorGgenT
Copy link
Member

KorGgenT commented May 8, 2020

no, that's what ammo restriction is for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON [Python] Code made in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants