Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_needs_extremes msgs for npcs #40294

Merged

Conversation

RedShakespeare
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Add check_needs_extremes msgs for npcs"

Purpose of change

Some extreme accidents like stim overdose, drunk, jetinjector overdose, etc. are now applied to npcs but the msgs are still only about the player.

Describe the solution

Change the related add_msg_if_player to add_msg_player_or_npc in check_needs_extremes(), and add npc's own msgs.

Describe alternatives you've considered

Limit these msgs for player and show nothing about npcs.

Testing

(Should work in theory...

Add msgs for npcs in check_needs_extremes()
@ZhilkinSerg ZhilkinSerg merged commit e84a43f into CleverRaven:master May 7, 2020
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership labels May 7, 2020
@RedShakespeare RedShakespeare deleted the npc_needs_extreme_msg branch May 8, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants