Make character::has_artifact_with non virtual #40181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My search missed an override derp. |
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
LGTM.com is reporting a warning about an invocation of Character::has_artifact_with() from the player constructor since it's a virtual function.
Describe the solution
Silence the warning by making has_artifact_with non-virtual, it is not overridden in any subclasses anyway and there is no reason to do so.
Describe alternatives you've considered
This call could occur in an init method instead.
Testing
The alert is not a sign of a valid issue, as there is only one definition of the function so it is the one invoked. As such there should be no change to the operation of the code.