Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make consuming take time #40117

Closed
wants to merge 30 commits into from
Closed

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented May 4, 2020

Summary

SUMMARY: Features "Makes consuming items take time"

Purpose of change

First part of #36972
Makes consuming items take time

Describe the solution

Added a new activity actor for consuming which uses the formula in the linked PR for times. Medicine/drugs weren't mentioned in the linked PR so for right now they all take 30 seconds.

Describe alternatives you've considered

Completing #36972 in this PR, instead decided to break it up and implement the rest of it in a future PR.

Testing

Spawned crack, crack pipe,bandages,antiseptic, can of soda, hamburger, wrapper of protein bar. Damaged limbs, used healing items, smoked crack, ate and drank the rest.

Additional context

src/activity_actor.cpp Outdated Show resolved Hide resolved
@ifreund ifreund added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Game: Mechanics Change Code that changes how major features work Mechanics: Character / Player Character / Player mechanics labels May 4, 2020
curstwist and others added 9 commits May 4, 2020 11:24
Core Foundation functions have names that indicate when you own a returned object:
Object-creation functions that have "Create" embedded in the name;
Object-duplication functions that have "Copy" embedded in the name.
If you own an object, it is your responsibility to relinquish ownership (using CFRelease) when you have finished with it.
Migrate inventory_ui.cpp and game_inventory.cpp to ui_adaptor
@Mecares
Copy link
Contributor

Mecares commented May 4, 2020

Great Idea, would it be hard to influence the time to consume something by traits, like make a character with rigid tablemanners or gourmand take longer to eat something and maybe some mutations make one eat faster?

src/activity_actor.cpp Outdated Show resolved Hide resolved
src/activity_actor.cpp Outdated Show resolved Hide resolved
src/activity_actor.cpp Outdated Show resolved Hide resolved
src/activity_actor.cpp Outdated Show resolved Hide resolved
@Ramza13
Copy link
Contributor Author

Ramza13 commented May 4, 2020

Great addition would it be hard to influence the time to consume something by traits, like make a character with rigid tablemanners or gourmand take longer to eat something and maybe some mutations make one eat faster?

I plan to do that in a followup PR when I do most of the rest of the linked PR.( I don't think I will add the optional eating speed stuff as that seems a little UI heavy for little gain).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Game: Mechanics Change Code that changes how major features work [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.