-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan for languages #40056
Merged
ZhilkinSerg
merged 6 commits into
CleverRaven:master
from
akirashirosawa:scan-for-languages
May 3, 2020
Merged
Scan for languages #40056
ZhilkinSerg
merged 6 commits into
CleverRaven:master
from
akirashirosawa:scan-for-languages
May 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbytheway
reviewed
May 1, 2020
jbytheway
reviewed
May 1, 2020
Co-authored-by: John Bytheway <[email protected]>
This was referenced May 3, 2020
ZhilkinSerg
added
[C++]
Changes (can be) made in C++. Previously named `Code`
Translation
I18n
labels
May 3, 2020
Cannot work well with Android OS...Hope for some fixing. |
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
I have to constantly switch languages for testing, and it’s very annoying to scroll through them all. I thought it would be nice if displayed only languages for which there is a translation. Then I found this in the code:
TODO: scan for languages like we do for tilesets.
So, let's do it!Describe the solution
Scan for languages like we do for tilesets. Added
lang
info to thePATH_INFO
added. Completely replaceactual_lang_options
nearlang_options
lang_options
byactual_lang_options
. Added probably forgottenbrake
infor
cycle.Describe alternatives you've considered
Reuse
lang
info, that I added toPATH_INFO
on thetranslations.cpp
:But, there are some scary
__ANDROID__
HACK
s and some strangedefined(__linux__) || (defined(MACOSX) && !defined(TILES))
instead of#if defined(DATA_DIR_PREFIX)
that inpath_info.cpp
.Testing
Language
option displays only available languages (for which there is a translation in .mo files).Additional context
I am using lambda expressions in C++ for the first time, it would be nice if more experienced contributor checked the code.