Add recipe to make technomancer's toolbelt, add gold infuser and corresponding recipe, edited copper and silver infuser and their recipe #40011
Conversation
|
Just realised that there is actually no change in this pull request. |
mlangsdorf
changed the title
|
I just commited my change, the reason why I was not able to commit it was I didn't write a summary |
|
As they are, the recipes for the gold infuser bracelet and the technomancer tool belts are not expensive enough. You're just turning a survivor's toolbelt into a significantly better toolbelt just because you're a technomancer. similarly for the gold bracelet into an infusion bracelet. i will say that i'm going to hold off on this PR until nested containers lands because then the toolbelt itself can get adjusted appropriately, but just buffing all of its tool qualities doesn't seem right. |
OK, I just made the belt a lot more difficult to make, and also reduced its abiility. But for the gold infuser, I am just repeating the pattern of copper infuser and silver infuser, I don't think it has any problem. |
|
and I also added a line of text to document MAGIC.md since it is just a small change I put it in this pull request instead of making another one |
|
can any one tell me what is "continuous-integration/travis-ci/pr" check? How to pass this check? |
|
It's a set of several tests that are run to ensure that the game still builds on several problems, and some guidelines are followed. As you can see here, it is complaining that this PR does not follow a formatting guideline. |
| @@ -44,14 +44,27 @@ | |||
| "result": "silver_infuser", | |||
| "category": "CC_ENCHANTED", | |||
| "subcategory": "CSC_ENCHANTED_TOOLS", | |||
| "skill_used": "fabrication", | |||
| "skills_required": [ "spellcraft", 3 ], | |||
| "skill_used": "spellcraft", | |||
There was a problem hiding this comment.
no. put this back. making infusers should not exercise your spellcraft. same for the gold one.
| "time": "40 m", | ||
| "book_learn": [ [ "alchemy_basic", 3 ], [ "necro_basic", 4 ], [ "techno_basic", 4 ] ], | ||
| "qualities": [ { "id": "CHISEL", "level": 3 } ], | ||
| "components": [ [ [ "gold_bracelet", 1 ] ] ] |
There was a problem hiding this comment.
now that we are getting to sufficiently high levels of mana infusing, i want this to take something in addition to the bracelet. maybe some of the crystallized mana dust that was added fairly recently. 40 minutes also seems a little low for a supposedly complex recipe that you only need to craft once.
doc/MAGIC.md
Outdated
| @@ -60,6 +60,8 @@ For example, this is the formula for spell failure chance: | |||
|
|
|||
| ```( ( ( ( spell_level - spell_difficulty ) * 2 + intelligence + spellcraft_skill ) - 30 ) / 30 ) ^ 2``` | |||
|
|
|||
| (Just to make it clear, this is not the resultant value of failure chance, for more detail, see function spell_fail in magic.cpp.) | |||
There was a problem hiding this comment.
this is misleading. instead it should mention that it caps out at an effective spell level of 30 at 0% failure chance.
There was a problem hiding this comment.
I think it not really necessary to write the complete detial of the calculation because it will be a long paragraph (to get the final value of failure chance, the process doesn't only include the if-then-else of 30-cap and 0-floor) . And I don't think it is misleading, it is true that the formula's result is actually not failure chance, just a medium value. Comparing to the original document which only state the formula, the new edition tells that there are more things to be processed to get the final failure chance value, and also provide a guide to find where the function is, obviously much better.
There was a problem hiding this comment.
Nevermind, maybe I can just write " the actual calculation doesn't really look like this" in stead of " this is not the resultant value of failure chance".
|
can you also revert all the changes you made to the technomancer toolbelt for now? with nested containers everything that can contain something in magiclysm is going to need to have a serious audit, but i'm waiting for a feature or two before i do so. that is currently the conflict, as well. |
Summary
SUMMARY: Content "Add recipe to make technomancer's toolbelt, add gold infuser and corresponding recipe, edited copper and silver infuser and their recipe."
Purpose of change
technomacer's toolbelt should be craftable, and the infusers should be mainly requiring spellcraft instead of fabrication. Besides, there are copper infuser, silver infuser, so why don't add a gold one?
Testing
I edited the JSON files and runed the game to test them.
Additional Content
Also add a line of text document MAGIC.md for issue #39952