Converting Materials From Strings To Arrays #39487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klorpa
requested review from
I-am-Erk,
John-Candlebury and
KorGgenT
as code owners
|
What is the purpose of this change? |
|
Could you actually fill out te template for the PR description? That would make reviewing it much easier. |
Enforcing JSON style consistency - use arrays for appropriate fields that support arrays. |
|
This is something that needs to proceed in small chunks, a large PR is going to accumulate conflicts faster than we can review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Converts all material tags from strings to arrays."Purpose of change
Describe the solution
Describe alternatives you've considered
Testing
Additional context