Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unshadow many variables. #39450

Merged
merged 3 commits into from
Apr 11, 2020
Merged

Unshadow many variables. #39450

merged 3 commits into from
Apr 11, 2020

Conversation

kevingranade
Copy link
Member

SUMMARY: None

Just more lgtm refactoring.

@kevingranade kevingranade force-pushed the kevingranade-lgtm-cleanup-next branch from 4a7f458 to fae151b Compare April 10, 2020 22:37
@kevingranade kevingranade changed the title un shadow a global Unshadow many variables. Apr 11, 2020
@lgtm-com
Copy link

lgtm-com bot commented Apr 11, 2020

This pull request fixes 20 alerts when merging fae151b into 486efb1 - view on LGTM.com

fixed alerts:

  • 18 for Declaration hides parameter
  • 2 for Local variable hides global variable

@ZhilkinSerg ZhilkinSerg merged commit 17329fa into master Apr 11, 2020
@lgtm-com
Copy link

lgtm-com bot commented Apr 11, 2020

This pull request fixes 20 alerts when merging ca583e6 into a79a050 - view on LGTM.com

fixed alerts:

  • 18 for Declaration hides parameter
  • 2 for Local variable hides global variable

@kevingranade kevingranade deleted the kevingranade-lgtm-cleanup-next branch April 14, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants